Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP PIE for installing extensions to docs #2521

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jnoordsij
Copy link

@jnoordsij jnoordsij commented Jan 2, 2025

Based on the discussion in docker-library/php#1554, PHP PIE is not likely to be included as part of the official PHP image. However, as it aims to replace PECL as the official way for installing PHP extensions, consumers of the PHP image should probably be informed on using this tool.

To Do/Discuss

  • Decide on whether or not to suggest an explicit way of installing PIE in the example, or just leave the reference to the docs as I did now
    • In particular the core extension zip is required, so installation is not entirely trivial
  • Check whether adding the deprecation notice for PECL is not a bit too eager
  • Pending what happens with Cleanup on aisle vendor php/pie#157, adding something like rm -rf ~/.composer ~/.pie to the suggested installation steps might be relevant to reduce the size of the built image
  • Wait for further upstream to become more stable

@jnoordsij
Copy link
Author

@asgrim (mentioning you as you've been helping out with php/pie#151): I've created this as a way to (hopefully) notify (new) Docker image users of PIE. However this is just a first stab from my side and would very much like some upstream feedback if you can provide any (or know of someone who can).

In particular regarding the stability/status I'm wondering if putting this in right now or at some later moment is more suitable, when it is more stabilized.

php/content.md Outdated Show resolved Hide resolved
@tianon
Copy link
Member

tianon commented Jan 7, 2025

Thanks for getting this started! I'm not outright opposed to including it, but I do have some reservations.

My primary reservation comes from having lived through the saga of https://github.com/golang/dep, which was a pretty "official" project, but still a WIP, and ended up completely abandoned, so I hesitate to give an explicit recommendation like this to users. Combine that with the notice at the top of https://github.com/php/pie ("PIE is still in early development. We welcome you to try this out, but please exercise caution when using PIE, as things may go wrong!") and I think we're probably still a little early here. I'm happy to be convinced otherwise, but I want to make sure I'm being clear in where (and why) I'm feeling reserved. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants